ARROW-9898: [C++][Gandiva] Fix linking issue with castINT/FLOAT functions #8096
+442
−162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
projjal
changed the title
Member
|
Would it be possible to add an example to cause SIGSEGV? |
projjal
force-pushed
the
castint
branch
2 times, most recently
from
5815a51 to
61b8485
Compare
projjal
changed the title
projjal
force-pushed
the
castint
branch
2 times, most recently
from
b1b3605 to
8af48ae
Compare
projjal
force-pushed
the
castint
branch
2 times, most recently
from
5e8059c to
36dc61d
Compare
Contributor
Author
I have added java tests that causes crashes |
Contributor
There was a problem hiding this comment.
did we make this an external function only for this message? whats the perf penalty for doing this..
Contributor
Author
There was a problem hiding this comment.
Not really for this message. As you can see from attached commits earlier I removed the std::stiring from error path in castInt, but the castInt function also started failing after this commit 8041ae5 (for the same reason as castFloat); earlier there was no dependency so it worked. Since it is not a header only library, we need to either compile all the dependent cc files, along with the precompiled functions, to llvm bit code; or move this function to a stub function. I think its better to move it to a stub function since the dependencies may change.
Contributor
|
also looks like this needs a rebase |
kszucs
pushed a commit
that referenced
this pull request
Oct 19, 2020
…ions Moving the castint/float functions to gdv_function_stubs outside of precompiled module Closes #8096 from projjal/castint and squashes the following commits: 85179a5 <Projjal Chanda> moved castInt to gdv_fn_stubs c09077e <Projjal Chanda> fixed castfloat function ddc429d <Projjal Chanda> added java test case f666f54 <Projjal Chanda> fix error handling in castint Authored-by: Projjal Chanda <[email protected]> Signed-off-by: Praveen <[email protected]>
projjal
added a commit
to projjal/arrow
that referenced
this pull request
Nov 14, 2020
…ions Moving the castint/float functions to gdv_function_stubs outside of precompiled module Closes apache#8096 from projjal/castint and squashes the following commits: 85179a5 <Projjal Chanda> moved castInt to gdv_fn_stubs c09077e <Projjal Chanda> fixed castfloat function ddc429d <Projjal Chanda> added java test case f666f54 <Projjal Chanda> fix error handling in castint Authored-by: Projjal Chanda <[email protected]> Signed-off-by: Praveen <[email protected]>
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
…ions Moving the castint/float functions to gdv_function_stubs outside of precompiled module Closes apache#8096 from projjal/castint and squashes the following commits: 85179a5 <Projjal Chanda> moved castInt to gdv_fn_stubs c09077e <Projjal Chanda> fixed castfloat function ddc429d <Projjal Chanda> added java test case f666f54 <Projjal Chanda> fix error handling in castint Authored-by: Projjal Chanda <[email protected]> Signed-off-by: Praveen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the castint/float functions to gdv_function_stubs outside of precompiled module